Add AbortSignal.abort() static method #9648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api
foolip
reviewed
Mar 29, 2021
| "version_added": "89" | ||
| }, | ||
| "firefox": { | ||
| "version_added": "88" |
There was a problem hiding this comment.
Confirmed in Firefox 88 beta, and that it's not in Firefox 87.
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
Co-authored-by: Philip Jägenstedt <[email protected]>
|
Thanks for review @foolip. I've fixed those suggestions. Let me know if you think we also need to remove the experimental flag on AbortSignal. |
|
@hamishwillee yes given how widely it is supported I think |
foolip
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbortSignal.abort() static method added to spec very recently
Should AbortSignal still be marked as experimental?